phunkyfish

Results 332 comments of phunkyfish

Check if applied locale correctly lowers chars and fallback

How will I know if they are readable? If there is a screenshot of what they should look like?

[clang-format] always use a line per constructor initialiser for longer lines

If you run clang-format using the above `.clang-format` but are using clang-format 8 does it give an error or ignore the option? I.e. can anyone using clang-format 8 check this?

[clang-format] always use a line per constructor initialiser for longer lines

As 20.04 is out soon maybe this can be revisited soon.

[clang-format] always use a line per constructor initialiser for longer lines

Ubuntu should be ok now: ``` Package clang-format-9 bionic (18.04LTS) (devel): Tool to format C/C++/Obj-C code [universe] 1:9-2~ubuntu18.04.2 [security]: amd64 i386 bionic-updates (devel): Tool to format C/C++/Obj-C code [universe] 1:9-2~ubuntu18.04.2:...

[clang-format] always use a line per constructor initialiser for longer lines

> You are missing Ubuntu Xenial and also the correct package for checking versions is clang-format instead of clang-format-. Ok, then maybe this waits for kodi 20. I don't follow...

[clang-format] always use a line per constructor initialiser for longer lines

> GitHub hides a part of the comment, I wrote `clang-format-` Cool, makes sense.

[clang-format] always use a line per constructor initialiser for longer lines

Ok, cool. Thanks @Rechi Shoud I check for `clang-format-9 `or `clang-format-9.0`. Is this sufficent: `find_program(CLANG_FORMAT_EXECUTABLE clang-format-9)`?

[clang-format] always use a line per constructor initialiser for longer lines

So like this: ``` find_program(CLANG_FORMAT_EXECUTABLE NAMES clang-format clang-format-9) ```

[clang-format] always use a line per constructor initialiser for longer lines

Ok, I’ll need a good hint so as I’m of ideas. Do you have a suggested change?

[clang-format] always use a line per constructor initialiser for longer lines

Will do. Thanks @DaveTBlake