phunkyfish

Results 332 comments of phunkyfish

The header commit is fine. However the bin-utils patch is not. There will be millions of different Linux installs for the current stable release and this patch could break them....

> > I recommend comping with ffmpeg6 on the Omega dev branch as this likely already runs with your binutils version. > > However, the patch to fix `src/libavcodec/x86/mathops.h:125: Error:...

@Mr-Groch can you try this PR: https://github.com/xbmc/inputstream.ffmpegdirect/pull/92 Testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/xbmc%2Finputstream.ffmpegdirect/detail/PR-92/1/artifacts

PR merged, so 1.19.4 should have the fix.

Can you add me on gitter.im and we can chat further there?

> I have no problem to open a PR in ffmpeg repo but I'm not sure to be the right person to do that ; I have absolutely no background...

Technically @tmm1 is an ffmpeg guy 😉 Similar to kodi there are parts of ffmpeg without maintainers. Generally the best way to get something fixed is to do some deep...

This would not be our oldest bug by far. Please bear in mind that the way to fix this is to get it repaired upstream. Getting things into ffmpeg can...

@fuzzard FYI, I thought we had fixed this problem. There is no issues with test builds of the addon in Jenkins. Maybe something that only causes an issue when building...

What’s more worrying is the discrepancy having building this project working but via Kodi not working. Will try to do some digging over Christmas to figure this out.