Philipp Stephani
Philipp Stephani
> @phst Shall we merge this? Yes, that's fine with me. We can fix the nits afterwards.
Thanks for the contribution, this makes sense. To write this as `rx` expression, you'd probably use something like: ```lisp (rx (or "/BUILD" "/BUILD.bazel" ".BUILD") eos) ```
Hi, just wanted to check whether you had a chance to look at this PR. Thanks.
Hi, did you have a chance to look at this PR? Thanks.
One thing that fails but could easily be fixed is the definition of faces. E.g. ``` (defface p4-link-face '((t :weight bold)) "Face used to highlight clickable links." :group 'p4-faces) ```...
The error about `:weight` is gone, thanks. The next error is about the missing function `completion-table-dynamic`.
FYI, I'm not using XEmacs myself, I'm just trying to `M-x load-file p4.el` and see what errors it prints.
I tried to trim down my environment as much as possible and still see the issue: ```bash env -i "HOME=$HOME" "PATH=/bin:/usr/bin" /opt/homebrew/bin/bazel --nohome_rc --nosystem_rc coverage --test_output=all --experimental_generate_llvm_lcov --nocache_test_results //a:test ```
Maybe the code in https://github.com/bazel-contrib/rules_python/blob/1.5.3/python/private/python_bootstrap_template.txt#L460-L476 should be skipped if the previous step hasn't produced a `.coverage` file?
> Maybe the code in https://github.com/bazel-contrib/rules_python/blob/1.5.3/python/private/python_bootstrap_template.txt#L460-L476 should be skipped if the previous step hasn't produced a `.coverage` file? OK, even that isn't enough because `coverage run` will generate a `.coverage`...