Philipp Stephani

Results 63 comments of Philipp Stephani

> Could you fill out the issue template and describe a situation where this doesn't work? Sure, here's an example (on macOS, with Bazel 2.0). WORKSPACE file: ```python # Copyright...

https://docs.google.com/document/d/e/2PACX-1vSDIrFnFvEYhKsCMdGdD40wZRBX3m3aZ5HhVj4CtHPmiXKDCxioTUbYsDydjKtFDAzER5eg7OjJWs3V/pub (linked from https://github.com/bazelbuild/bazel/issues/10022) contains at least some information about the expected interface for runfiles libraries. While this is only directly geared towards the native rules, it's probably a good...

BTW, I've created such a package (https://pkg.go.dev/github.com/phst/runfiles), and I'd be happy to contribute it to this repository.

> Is it possible to move the golang implemenation to https://github.com/bazelbuild/bazel/tree/master/tools? I don't think that's technically feasible because AIUI it would require Bazel core to depend on rules_go, which would...

Maybe this got fixed again by a change in Go 1.15 (https://go.dev/doc/go1.15#testing): > `go test -v` now groups output by test name, rather than printing the test name on each...

Sorry for the delay, here's another transcript on a different machine (on macOS, but the symptoms are the same): Before cloning the buffer: ```none [internal] Sat Apr 23 21:07:44 2022:...

Right now TOOLS_NOGO is a proper superset of the checks run by `vet = True`, so it's safe to remove the `vet` attribute for now. But probably the `nogo` wrapper...

Hmm, the CLA bot is still complaining...

Hi Nic, could you please merge this PR? Thanks!