Felix Prillwitz

Results 162 comments of Felix Prillwitz

Did you check against the official clients how they behave on transfer? That might be a limitation from the clients, even tho the later described behavior is quite weird.

Okay, good to know. I think I quickly tried to do it from the web player to the desktop client and it didn't seem to work. So maybe that was...

Thanks for all the additional info :). To fix this we might probably need some tinkering with the data send to the server. So might take a while until this...

Just looked into this issue again. I usually test with the web-player and when transferring from librespot to the web-player it transfers correct, but when transferring to the desktop or...

Additionally it seems to only affect the liked songs? I couldn't reproduce the issue with the reset of the position in a playlist (had 3 tracks for easier inspection of...

So I did try to adjust some metrics and parameters that didn't quite match the state that the web or desktop player send, but it didn't seem to fix the...

I didn't look fully through it, yet. But what is the behavior when the `Mutex` gets poisoned, did you test/encounter that, yet?

So whats the state of things here @roderickvd? Could you resolve the conflicts and the review comment if everything is ready to merge?

I'm not sure if this fully fixes #1382, but besides that this sounds seems like a good thing to do. @kingosticks anything from your side that speaks against these changes?

I think if we don't need to do another request and can just forward it on `AudioItem` nothing speaks against doing it. If you look at `UniqueFields::Episode` there is already...