photostorm

Results 16 comments of photostorm

Windows is currently not supported in the master branch

There should be high bar to justify incompatible changes to the interface. Due to the return type of Start, I do not see a way to pass the handles. I...

ok, I will look into it. Thanks for your feedback. @kr

@kr I do not think I can used that. there is window handle that I need access to also.

Is there anything that can be done with "The operation completed successfully." being reported as error when calling CreatePseudoConsole or Resize?

@jeffreystoke I made an attempt to fix the issue I was talking about and seeing if I could fix render bug. I do not work with Windows a lot. I...

[pty-patch.txt](https://github.com/creack/pty/files/7084009/pty-patch.txt) I created a patch file for you.

@jeffreystoke Looks good to me. Nice work.

I think we fixed a lot of usability issues. I have tested it with powershell. ``` var f pty.Pty var err error f, err = pty.Start(exec.Command("powershell")) if err != nil...

@creack I know it been a couple months, but what are the tasks you would like done for windows support for it to be merge. I can continue PR.