Phong Do

Results 4 comments of Phong Do

Hey @ntBre 👋 I've got this PR up with a suggestion to address the issue https://github.com/astral-sh/ruff/issues/19576. Please take a look whenever you have a moment. Thank you 😄

> I still need to review more closely Sure, please take your time 🙏 > Could you take a look at the ecosystem check too? I don't think we should...

> Overall, I think we should just avoid a diagnostic and fix entirely in both of these cases to avoid trying to differentiate between comments it's okay to delete and...

@ntBre I reverted the unsafe fix and kept only the `body_range` fix [here](https://github.com/astral-sh/ruff/pull/22079/changes#diff-11a16368fae4b28fc3b47729a9db05e583106d078120ecbf523de5ab43de6773R176). This change would skip the diagnostic and fix entirely where branch comments differ. I also added a...