Pedro Henrique Marinho Bressan
Pedro Henrique Marinho Bressan
> I understand your points. > > Just to check on this first: > > - Are you okay with us having multiple methods to perform the same operation but...
Could you elaborate a bit more on why is this implementation an advantage over the current one, forgive me if I am mistaken, but my interpretation is that: - The...
I forgot to comment in the review: - There must be a warning in the `Flight` class if a `Rocket` has `AirBrakes` and `overshootable` is `True`. The same apply for...
Also, @Lucas-Prates could you add this PR to the `CHANGELOG.md`?
> a few tests are not passing locally... > Thanks for testing it. I will check what is happening.
I have just noticed that I made a mistake when merging CHANGELOG conflicts for this PR. I will fix it before merging. This does not block reviewing. - [x] Fix...
> One last test we could run is: Create a Monte Carlo simulation with 100 simulations and verify if the output .txt files are still readable enough. Good point. I...
> The `monte_carlo_class_usage` notebook currently does not work with parallel, I did not have time to look into it, and so I did not review the parallel part of the...
I have pushed a fix for the issue on file writing when running on Windows (more accurately on processes [`spawn` mode](https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods)). I have tested it on a Windows machine and...