John Mulligan
John Mulligan
We're probably going to start making use of the function ousrelves in cephfs/admin for any functionality not currently handled directly by a mgr command (there appear to be a few)....
I personally prefer bullet 4 - MonCommand2 - but I am willing to admit I'm often overly fond of backwards compatibility. But in this case I do think the maintenance...
``` === RUN TestCancelClone clone_test.go:205: Error Trace: clone_test.go:205 Error: Received unexpected error: rados: ret=-22, Invalid argument: "Traceback (most recent call last):\n File \"/usr/share/ceph/mgr/mgr_module.py\", line 1701, in _handle_command\n return self.handle_command(inbuf, cmd)\n...
I filed https://tracker.ceph.com/issues/55583 to see if we can get some feedback from the cephfs team on this.
The fix for the issues has been merged into ceph's main branch. Hopefully the backports will land soon too.
Backport PRs: * https://github.com/ceph/ceph/pull/47747 * https://github.com/ceph/ceph/pull/47748
new backport batch pr for pacific: * https://github.com/ceph/ceph/pull/47112
Fixing this should largely just be a matter of allocating C-memory and storing C-pointers into our structs right?
Also, do you have any thoughts on why this wasn't caught by the stricter checking we enable with the env var?
No, generally you can assume something has not been investigated yet when there's no assignee, other comments or PR. However, comments like yours help us know there is interest in...