John Mulligan

@ansiwen @anoopcs9 how do you feel about having only the tests behind the build tag? The code is all changes to existing structs and is backwards compatible with older mgrs...

Right, it should probably have preview in addiiton to ceph_main where ceph_main is present. Splitting the code up is (I think) not worth it because the changes are a new...

Updated. fixed the build tags on the test

> Oh.. PR is still in _Draft_ state? I take the liberty to mark it as ready. Oops, thanks. I had left it in draft for deciding on the code...

Regarding making things harder for a user of the API - I had suggested two ways of putting some of the code behind a build tag: (a) was to move...

I have not tried this at all, but I think the "n": "N" flag indicates that there are multiple arguments - an array in json parlance. Try breaking your "args"...

Hi, I'd like to help more but unfortunately I'm not quite sure what the issue is. I have little direct experience with injectargs command. What I suggest is to try...

CC: @thotz @leseb

I'm not so keen on trying to "manually" extract the data from YAML files without a YAML parser. Given that near future versions of cephadm will be able to include...

Fair enough. Sometimes I feel the need to formally raise a flag even if there's probably a justification, just to make sure there is. :-) I'll try and do a...