John Mulligan

Results 191 comments of John Mulligan

> Sorry @phlogistonjohn I don't have much bandwidth lately to review PRs sweat_smile I had a quick look at it, and I struggled a bit to follow why some CLICommands...

> > Just so I'm clear - what do you mean by devel docs in this context: comments and docstrings in the code OR more formal rST based docs in...

@epuertat new docs added. I didn't cover all the aspects of object_format but the highlights, including the new decorators. I'd be happy to expand on it but I feel that...

@ajarr I'd like you to take a look if you have the time. However, in order to not wait an overly long time I'll probalby ask @adk3798 to merge this...

> @phlogistonjohn I think this may be causing a couple test failures > https://pulpito.ceph.com/adking-2022-08-12_20:56:57-orch:cephadm-wip-adk-testing-2022-08-12-1411-distro-default-smithi/ OK, thanks for letting me know. I'll be looking into it soon.

> One question though. In NonFatalError definition, was it intentional to output self.msg in the stdout position instead of stderr position of the return tuple. I guess it doesn't really...

The corresponding changes have not been commited to ceph yet. Tests are expected to fail until https://github.com/ceph/ceph/pull/47934 is merged.