Philippe Scorsolini
Philippe Scorsolini
with the regex above it would return: `The Configuration "configuration-downgrade" is invalid: spec.package: Invalid value: "crossplane/e2e-nested-configuration:v0.2.0": spec.package in body should match '^[^\.\/]+(\.[^\.\/]+)+(\/[^\/:@]+)+(:[^:@]+(@sha256.+)?|@sha256.+)$'` which is hardly more readable 😆
the regex can be run as a CEL rule, so we can customize the error message: ```go // +kubebuilder:validation:XValidation:rule="self.matches('^[^\\\\.\\\\/]+(\\\\.[^\\\\.\\\\/]+)+(\\\\/[^\\\\/:@]+)+(:[^:@]+(@sha256.+)?|@sha256.+)$')",message="must be a fully qualified image name, including the registry, repository, and...
Regarding the migration, we should add a pre-upgrade hook checking that all packages are using a fully qualified image and suggest migrating before upgrading maybe?
> when a package without an explicit registry is applied to the control plane - CEL rule validation could definitely happen here and reject the apply, right? Yes, except for...
@jbw976 > Will our CEL validation be too strict here, and possibly reject valid package paths because they have too many segments? No, it will allow that, see tests [here](https://regex101.com/r/p82ESW/1).
go.mod's directive is only the minimum required version, what matters is the version of the go binary, which is set to 1.22.3 in [ci](https://github.com/crossplane/crossplane/blob/a8b579d82b7d7d3da20ce179bfe6f9a6b04df3d7/.github/workflows/ci.yml#L13). I have to go through it...
🤔 you are right, I didn't realise what it was complaining about 🤔
Hi, sorry, I'll make sure to have a look at it tomorrow. Could you rerun the benchmarks after the fix as @jbw976 was suggesting in the meantime?
> * Grouping should be made per root test. E.g. subtest should not be logged as separate groups. I arrived here looking exactly for this, it wasn't implemented in the...