Philippe Scorsolini
Philippe Scorsolini
Option A sounds like the right thing to do indeed, we were too quick switching the storage version right away. I think we did that in the past, but we...
Yes, this is correct, functions can not do this today, https://github.com/crossplane/crossplane/issues/4729 should cover this capability. Regarding the docs, it is indeed wrong, currently functions are not called on deletion.
Cc @Fricounet as original author
@MisterMX so this is validating the merged result of the selected EnvironmentConfigs, but not the in-memory environment after applying patches, right?
Indeed I would leave patch validation to the webhook/crossplane-lint, I was more referring to an after the fact validation, if your patching results in an invalid environment in the end...
@MisterMX, would you be interested in moving this to function-environment-configs?
a possible regex to validate packages could be `^[a-zA-Z0-9]([a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])?(\.[a-zA-Z0-9]([a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])?)+(\:[0-9]+)?\/[a-z0-9]+([._\-][a-z0-9]+)*(\/[a-z0-9]+([._\-][a-z0-9]+)*)*\:[a-zA-Z0-9][a-zA-Z0-9._\-]*$`, but I'm not sure it's worth enforcing, maybe we should just improve the runtime error... WDYT?
> What do you think about using a simpler regex that doesn't attempt to fully validate an OCI reference, but instead only rejects OCI references that are missing a registry?...
@jbw976 > why would we need to write our own regex for validation? Would the validation functionality in https://github.com/google/go-containerregistry not be reusable for our needs? > is it so we...