phiresky

Results 404 comments of phiresky

The socks issue can probably be fixed by replacing `requests` with `requests[socks]` in pywb/requirements.txt

The same file is also works correctly in browsers

replacing this: https://github.com/xtuc/webassemblyjs/blob/0fb788b1b7785f2dcbb1b2e03b6564f607b4358c/packages/wasm-parser/src/decoder.js#L1836 with ` offset = startLoc + sectionSizeInBytes` works, so seems like the issue is the offset is wrong after failing to decode the name section.

By the way, my use case for this extension is completely different from KeePass, so I could fork it I guess, but the above still applies to the original use...

As far as I understand, subtree: true only applies to children of the watched element - which is `` and not ``. So really there shouldn't be any performance impact....

tbh I don't see how that explains misdetection? Why does traversing a tree explain a wrong detection? Even if the answer is ambiguous, I don't see why it can't either...

Just fyi, current master does not work (deadlock here: https://github.com/aahancoc/tree_magic/blob/9bc1f46eeda7985aa06ecb1b4f0dc8c306706f8c/src/lib.rs#L702 )

Looks to me like the [full official decoder](https://github.com/google/brotli/tree/master/js) (js version) is only 150 kB (70kB compressed) check out this complete example: https://gist.github.com/phiresky/ff29eeef882aaf002d7b747ec04f6113

The decoder is easy, but looks like it's harder to find a working, compact JS encoder for brotli without external dependencies.

Just for fun, I compiled the [Rust Brotli](https://github.com/dropbox/rust-brotli) implementation to WebAssembly. It works pretty well, the encoder is 970kB (470kB compressed). See here: https://phiresky.github.io/rust-brotli-wasm/brotli-wasm-bindgen/dist/example.html ([code](https://github.com/phiresky/rust-brotli-wasm/tree/master/brotli-wasm-bindgen/dist)) No idea if all browsers...