phiresky

Results 404 comments of phiresky

What you're saying makes sense with the disambiguating attribute not really being a class member at all. I think the core issue is that there's no real standard integrated way...

Your example is actually better than I thought, because now the second parameter of your `configure_tagged_union` function is the Union[], instead of an outer attrs class as in your previous...

just want to mention that there's pandoc filters that directly convert math equations to inline SVGs: https://github.com/shreevatsa/pandoc-mathjax-filter (have not tried them) which if it works might be a great idea...

the version with padding looks pretty good to me as well

uhhh to be honest not really.. looks like fixing that is a pretty deep dive, since it only works when a property in the "application manifest" (what even is that?)...

This PR works beautifully for me. I'm using it to create this extension: https://github.com/phiresky/sqlite-zstd One question I couldn't figure out by reading https://github.com/jgallagher/rusqlite/issues/524#issuecomment-507787350: How is the best way to test...

I've updated this PR to work with the current version of rusqlite here: https://github.com/phiresky/rusqlite/tree/gwenntest Seems to work, just needs recreation of the bindgen files for the non-bundled versions.

Uh probably not, I'm just a random person, I don't have access to this branch and am not enough knowledge to actually champion these changes (e.g. I might have broken...

I have opened a new PR here: #868

> My suggestion for a compromise would be to add a CONTRIBUTORS file [...] That looks like a great solution! I've closed the other PR. Can we merge this now?...