Scott Mansell

This is not going to degrade correctly if there is an android build that doesn't find OpenSLES. Also, OpenSL ES is technically a cross-platform API. Do we really want to...

Also, you remove `AudioCommon/OpenSLESStream.h` from the list of sources, but it's included anyway?

> It also removes an optimisation where a lookup table for each physical address.....did not seem to improve performance in any noticeable way I hesitate to remove such an optimisation...

You can rebase this now, c++20 was merged.

Why has it decided to do that? Is there a reason in the c++ spec that doesn't allow indexing into a statically calculated constexpr result, or is it just a...

Why?????? Quickly skimming, most (if not all) of these are just POD types, and there is no performance difference between postfix/prefix operators. Even if our coding guidelines do say prefix...

Previous mass changes like this were typically done so we could get the advantage of running automated tooling, like clang format on every commit. Which was well-worth it. Nothing like...

Yes, that helps mitigate the issues. But my question is still "Why??????" And in my personal opinion, "to better conform to style guidelines" is not a good enough answer.

> My only guess is I also changed the generated shaders to use pre-increment in their for loops as well. Which is part of my point. Now you are paranoid...

> If you don't want people to make style changes, change the style. I don't really want to argue against this point in the style guide. Perhaps what we should...