Phil Pearl comments

Results 22 comments of


                                            Phil Pearl

fix(bigtable/bttest): make table gc release memory

Ah, actually, scratch that. It's still not safe. I'm not convinced it was safe before as GC was changing the cell slices, but this has certainly made it more obviously...

fix(bigtable/bttest): make table gc release memory

Ah, no, wrong again. I think this version is good. The row lock protects us.

fix(bigtable/bttest): make table gc release memory

Wrong a third time! We need to re-check the rows as we delete them with a lock held. It could be that cells have been added to the row in...

fix(bigtable/bttest): make table gc release memory

Any chance of getting this merged?

fix(bigtable/bttest): make table gc release memory

@jimfulton do you have any suggestions about what the test would look like and what it would test? Presumably there are already tests that the GC operates correctly in terms...

fix(bigtable/bttest): make table gc release memory

Well past the first anniversary of waiting for a review...

fix(bigtable/bttest): make table gc release memory

I've raised an issue. https://github.com/googleapis/google-cloud-go/issues/6102. I'm afraid I didn't understand what type of test jim fulton was expecting and he didn't answer my query.

fix(bigtable/bttest): make table gc release memory

Hi @telpirion - any further thoughts? Are you up-to-speed yet?

nsqd: Use Klaus Post's compression libraries

Fabulous. I'll put together a PR for the dependency swap.

nsqd: Use Klaus Post's compression libraries

Hmm, I think our original testing must have been flawed when looking at Snappy. The Klaus Post version of this seems to be slower than the Google version, and the...