Philip Watson

Results 14 comments of Philip Watson

I'm currently experimenting with this feature (though I'm not an AMP expert). You can use the standard vendors in the rtc-config: simply by adding the "vendors" field. eg: `rtc-config='{"vendors": {"prebidappnexus":...

Hi @bretg Yes, the "script" RTC callout is `["amp-script:targetingFns.getTargeting"]`. Regarding the url: I mean the function that this RTC points to (getTargeting) doesn't return a URL. Sorry, I think I...

Hi @SyntaxNode Here is my example. **But there is a problem**: AMP does not support query params on the script URLs. This is needed to pass in placement-level parameters `placementId`,...

Hi @SyntaxNode The example works as-is. But we run into trouble if we want to support multiple ads on the page. There are "hacky" workarounds. It only depends on it...

Hi @Alexander-Kane I found the problem in the code. Not sure how to tackle it yet. I haven't really considered the scenario where the website changes the video source. Usually...

Funny that, I've been thinking about it recently. The answer is yes. Most likely in the next month or two. In the meantime you could install directly from github using...

@nachoaguirre Thank you for your feedback. Will look into them when I find the time. Currently addressing VPAID issues at the moment.

Hi @nachoaguirre What do you think? Does it work for you?

Merging this. If not ok with it, just open another PR or issue :)

@nachoaguirre you ok with this? This affects a recent change of yours.