Philipp Rudiger
Philipp Rudiger
>I haven't looked at the details here, but if you are trying to make a parameter not appear and not be used in a subclass That seems like a weird...
Or in this case it might be reasonable to invert the hierarchy and have DatetimeRangePicker inherit from your DateRangePicker.
This seems completely reasonable to me. My only concern here is that `detail` may contain certain objects which can't be naively serialized to JSON and will therefore error, e.g. `Undefined`...
> @philippjfr I would go for trying to serialize to JSON and abort with a console error in case it fails This seems reasonable and shouldn't ever be too expensive.
For now let's just roundtrip it through `JSON.stringify` and `JSON.parse` so it drops the unserializable parts.
Thanks for your patience with this one @keul!
Looking good to me! Not entirely sure `fixed_start` and `fixed_end` convey the concept of a hard bound but don't love `hard_start` and `hard_end` either. Any other suggestions? Separately I think...
Maybe let's move away from the "hard" connotation and instead describe what it actually bounds, e.g. `editor_start` and `editor_end`? Ping @maximlt and @jbednar for votes/suggestions.
For compatibility with other sliders the `start` and `end` values will continue to determine the slider bounds. Adding additional parameters to control the minimum and maximum values that can be...
I'm actually okay with `fixed_start` and `fixed_end` now since the semantics are that start/end can be overridden by manually entering a value but the `fixed_` bounds cannot. Just want to...