Philipp Hofmann

Results 731 comments of Philipp Hofmann

The C++Exceptions seem pretty broken. Luckily, we can copy fixes from [KSCrash](https://github.com/kstenerud/KSCrash). I have a hacked-together solution with stacktraces and a proper error message here: https://github.com/getsentry/sentry-cocoa/compare/fix/cpp-exceptions?expand=1. I still need to...

Hey all, I just opened a hacked draft PR https://github.com/getsentry/sentry-cocoa/pull/5128. Unfortunately, I underestimated the effort a bit. I still need to write a few tests and do proper testing. I...

We just merged the PR to fix this. In the next release, you can enable `options.experimental.enableUnhandledCPPExceptionsV2 = true` to get proper stacktraces for fatal C++ exceptions. Please keep in mind...

> benefit is that you guarantee crashes from previous runs are flushed. We have the start up crash logic that would ensure crashes get flushed out in case your app...

With the current approach, whenever you start the SDK, it checks on the main thread if there are envelopes to send. Moving this check to a BG thread impacts every...

> Just one suggestion, I would prefer to have less assets (in this case the icons). With cocoapod or SPM, our users download all the samples too the less bits...

> cc @philipphofmann @romtsn to confirm Yes, it should.

The app context would be the place to go https://github.com/getsentry/sentry-cocoa/blob/f96ab191e62125a645c846318e73eb96dc0a5794/Sources/Sentry/SentryClient.m#L736-L747 But the logic in the client only works for non-crash events. For crash events, we would need to store that...

@brustolin, we actually have a different solution for this; see [docs](https://docs.sentry.io/platforms/apple/guides/macos/usage/#capturing-uncaught-exceptions) You only need to set this flag. ``` UserDefaults.standard.register(defaults: ["NSApplicationCrashOnExceptions": true]) ``` We also use this in the macOS...

We see very few instances of this in our [internal SDK crash detection](https://sentry.sentry.io/issues/?project=4505469596663808&query=is%3Aunresolved%20sentrycrash_scopesync_addBreadcrumb&referrer=issue-list&sort=user&statsPeriod=30d). I also double checked the code `sentrycrash_scopesync_addBreadcrumb` and `setField` and was unable to find any potential issues....