Philipp Hofmann

Results 731 comments of Philipp Hofmann

@hovox, yes something like that. But we should ensure we're only attaching the debugMeta that is referenced in the stracktrace as we do it in the client https://github.com/getsentry/sentry-cocoa/blob/688aac7424ee0c46592516bc52c227307e902074/Sources/Sentry/SentryClient.m#L736-L737 Otherwise, we...

I think it's acceptable to do this even in a non major because you [have to use Xcode 16 to submit apps](https://developer.apple.com/news/upcoming-requirements/?id=02212025a&utm_source=chatgpt.com) and you now can't use iOS 11 anymore...

> if we really want to call this a fix vs a breaking change, we should wait until the version of Xcode that is forcing this is actually supported to...

Those are valid points, @armcknight. So let's do it properly and do this with a major release. It's worth noting that we don't have to tackle all major items in...

I'm for closing PRs that we don't plan on merging soon. Too many open draft PRs are a bit of noise and I would like to keep the number low.

@denrase, I think it would be great if you could open an extra PR for renaming the existing internal logger. It would make reviewing this PR way easier. I don't...

It looks like the crash happens here https://github.com/getsentry/sentry-cocoa/blob/3b2f6027812abea089dea822726c1be86d3d612b/Sources/Sentry/SentryBreadcrumb.m#L33 @sindresorhus, do you manually add breadcrumbs that set something to `SentryBreadcrumb.data`?

Thanks for the update, @sindresorhus. What do you put into `data`? We need to check why we get `Attempted to dereference garbage pointer 0xdeadbeef.` when serializing the data.

Thanks for the update, @sindresorhus. I (and also @armcknight 😀) wonder why we are using `strong` instead of `copy` for this property on `SentryBreadcrumb: @property (nonatomic, strong) NSDictionary *_Nullable data;`...