Philipp Hofmann comments

Results 731 comments of


                                            Philipp Hofmann

CI to run and bump the sentry-cli automatically and run tests

Thanks for looking into this, @denrase. > I wrote a script (locally) that fetches the latest version from the sentry-cli repo and downloads it to a subfolder. Can you maybe...

Allow manually specifying application id, version name and code

Hey @lwasyl, thanks for explaining why you need this feature. If the sentry-cli supports the UUID for the proguard upload I don't see any reason why we shouldn't support it...

Allow manually specifying application id, version name and code

We are also happy to accept PRs if you are motivated @lwasyl ;)

Allow manually specifying application id, version name and code

Thanks for pointing that out, @lwasyl. I replied in the PR https://github.com/getsentry/sentry-fastlane-plugin/pull/80#issuecomment-1106423836.

Allow passing multiple files to sentry_upload_sourcemap

Thanks for reporting this, @acaldas. So you currently have a workaround with using sentry-cli directly, right? Anyways we should fix `sentry_upload_sourcemap` to support your use case.

Automatic create a new PR to Bump CLI version

Was done with https://github.com/getsentry/sentry-fastlane-plugin/pull/144.

Add tests for the Native Bridges

I wouldn't mind having two issues and / or two PRs so they get merged faster.

Add tests for the Native Bridges

Integration tests make more sense because even if the unit tests are green the functionality could be broken because the underlying functionality changed.

`attachThreads` should attach native threads even if the exception comes from Dart/Flutter

Negative aspects of this issue: 1. Getting the stacktraces of all threads from the native layers adds some overhead. 2. Most of the time native threads won't help you to...

Support HTTP response body if sendDefaultPii and maxResponseBodySize are enabled

I added it to the next TSC, @bruno-garcia, and @marandaneto.