sentry-fastlane-plugin icon indicating copy to clipboard operation
sentry-fastlane-plugin copied to clipboard

CI to run and bump the sentry-cli automatically and run tests

Open bruno-garcia opened this issue 3 years ago • 4 comments

"Dependabot, but for Sentry CLI":

The CI could bump sentry-cli to the latest version and see if there are any issues. Ideally the trigger is defined by a release on sentry-cli. Please make sure it includes previews (the main goal) Triggering from here might not be possible, but we could setup the action on the sentry-cli repo to trigger a workflow here that creates a PR with the change.

Ideally this setup will work also for other plugins such as:

  • https://github.com/getsentry/sentry-dart-plugin/blob/main/download-sentry-cli.sh
  • https://github.com/getsentry/sentry-android-gradle-plugin

bruno-garcia avatar Apr 27 '22 15:04 bruno-garcia

@bruno-garcia I'm in the process to figure this out. Here's what i have so far:

  • This repo does not bundle sentry-cli but uses the one installed on the host system, but we can provide a pram with a custom path.
  • I wrote a script (locally) that fetches the latest version from the sentry-cli repo and downloads it to a subfolder.
  • We could run this scheduled with an action (cron). Not super cool, as we are polling the whole time, but we can stay in the scope of this repo (for now).

So far so good, now we have the most recent version in our hands and could proceed. The main questions is now, what do we mean by see if there are any issues and what should we actually test? Are there any end-to-end tests we can run using the plugin in tandem with the most recent sentry-cli?

Assuming we know how to test, we could then open a bugfix PR which has the error message in the description.

denrase avatar May 30 '22 14:05 denrase

Thanks for looking into this, @denrase.

I wrote a script (locally) that fetches the latest version from the sentry-cli repo and downloads it to a subfolder.

Can you maybe share the script here in the issue, so it doesn't get lost?

We could run this scheduled with an action (cron). Not super cool, as we are polling the whole time, but we can stay in the scope of this repo (for now).

Once per day should be okay.

what should we actually test

I would say this is the most important use case https://github.com/getsentry/sentry-fastlane-plugin/pull/128

Assuming we know how to test, we could then open a bugfix PR which has the error message in the description.

I don't fully understand this. A bugfix PR with which error description?

philipphofmann avatar Jun 10 '22 08:06 philipphofmann

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jul 02 '22 00:07 github-actions[bot]

Hi @denrase. Is this already done? If so, close this please with a reference to the PR.

Thanks!!

brustolin avatar Sep 28 '22 13:09 brustolin

@brustolin Yea, done in https://github.com/getsentry/sentry-fastlane-plugin/pull/144. Sry for the delay!

denrase avatar Oct 25 '22 13:10 denrase