philipp2100

Since this a library, you should also add -fPIC here. Maybe also in other places; for me this suffices, but I'm not familiar with your build system and how other...

You're using #!/bin/sh here, though you use bash extensions like pushd. This should be #!/bin/bash. https://github.com/sahlberg/libnfs/blob/030814506e529ef1f1572c7b6e3fc2e4c10cb544/packaging/RPM/makerpms.sh#L1

"Read browsing history" permission

1

Is this permission really necessary? If so, I suggest to quickly explain why in the README, since it's a serious issue for users concerend with their privacy.