Philip Craig
Philip Craig
This crate has a lot in common with faerie, but it presents a lower level API. Need to investigate how much scope there is for sharing with faerie. cc @m4b...
For defined symbols, faerie always references the section symbol in ELF relocations: https://github.com/m4b/faerie/blob/dcb671a99faa32b72fac88d2406e952a41844636/src/elf.rs#L676 I think this means that these relocations can never be preempted. However, my understanding is that normally...
The relocation fields are bitfields, which makes the ordering all weird. Currently we only use the little endian ordering, but that won't work for big endian files. LLVM has code...
The use of `object` in the public API means that breaking changes in `object` are breaking changes in this crate, and `object` necessarily has a large evolving API so breaking...
In https://github.com/jonhoo/inferno/pull/14#issuecomment-459752419, @jonhoo said: > The `un_inline` function introduced in this PR has to: > > * open the file > > * pass it to `object::File::parse` > > *...
Even though the DWARF 5 standard says "The value 0 indicates that no source file has been specified.", discussion on the DWARF mailing list indicates that this was an oversight....
This change is intended to be transparent to users. However, I did have to add a `T: Clone` bound for implementations of `ArrayLike`. r? @nbdd0121
Errors that have been seen in the wild, and thus likely to be useful to check: - [ ] `DW_AT_abstract_origin` points to a DIE with the wrong tag (e.g. `DW_TAG_inlined_subroutine`...
When parsing units in various sections, we return an error if the version is unknown, which terminates iteration. This means we operate poorly with unknown DWARF versions (e.g this occurs...
In #514/#515, parsing failed because some attributes used `DW_FORM_GNU_strp_alt`, but no supplementary object file sections were loaded. The error value (`UnexpectedEof(ReaderOffsetId(4497503920))`) made it hard to determine the cause. We should...