Blaine Bublitz

Results 267 comments of Blaine Bublitz

fwiw, ts-node 10 supports `.cts` extension, which would allow hardhat.config.cts to remain compiled to commonjs even if it is within a `type: module` project.

> Maybe this is the time to re-evaluate full ESM compatibility? "Full ESM compat" is impossible in hardhat before the next major. Hardhat's task system relies entirely on the order...

> Hard, to refactor without breaking changes, yes maybe ... But not impossible! It's not about the hardhat implementation itself. It would be an ecosystem level breaking change. Everyone's hardhat.config...

@robwilkes this is the very first, minor step into getting some semblance of interopt with `type: module` projects. Please hang tight until we can get things working together. As for...

chai-spies is really slim in features and didn't work for many use cases I had. I submitted a PR to Sinon.JS to add AMD (since it was never suggested before).

SinonJS accepted my PR for AMD support https://github.com/cjohansen/Sinon.JS/commit/7bf869e435b728e7c4a64ea845daa0db5ee89dd2

Yeah, I was wondering if doing something similar to Expressions was desirable. I'm fine implementing like that, but it'll add more work, which I'll have to find some time to...

Thanks for the guidance folks! I tried to replicate patterns I had seen elsewhere in `binaryen.js-post.js`. Please take a look and let me know if I should be doing anything...

@kripken thanks for the feedback! I've made the updates you suggested

@sttk if this is the full example, you've forgotten to create a Writeable stream, so it never sinks and you hit the highWaterMark