outline icon indicating copy to clipboard operation
outline copied to clipboard

Component: `@phase2/outline-core-button`

Open bardleb opened this issue 1 year ago • 5 comments

Summary by CodeRabbit

  • New Features

    • Introduced a new OutlineCoreButton component with customizable variants and sizes.
    • Added a search bar to the main interface for enhanced navigation.
    • Implemented a pre-commit hook to ensure code quality.
  • Enhancements

    • Updated button styling with new CSS variables for primary, secondary, tertiary, and link variants.
    • Improved button responsiveness and added new sizing options.
  • Bug Fixes

    • Removed unused tailwind.css import to streamline styles.
  • Documentation

    • Added comprehensive documentation for the OutlineCoreButton component in Storybook.
    • Updated CHANGELOGs for various packages to reflect new additions and changes.
  • Refactor

    • Renamed AdoptedStylesheets to AdoptedStyleSheets for consistency.
  • Style

    • Reformatted Storybook CSS for better readability and maintenance.
  • Chores

    • Deprecated the original button component in favor of the new OutlineCoreButton.

bardleb avatar Aug 01 '23 14:08 bardleb

⚠️ No Changeset found

Latest commit: 6e861ad4ad203d37b22a74f98e72adaaa57a50f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 01 '23 14:08 changeset-bot[bot]

Deploy Preview for outlinejs ready!

Name Link
Latest commit 6e861ad4ad203d37b22a74f98e72adaaa57a50f2
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/65c2408526cae30008de5cbf
Deploy Preview https://deploy-preview-410--outlinejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 01 '23 14:08 netlify[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@phase2/[email protected] None 0 0 B
npm/@phase2/[email protected] None +1 441 kB himerus
npm/[email protected] None +6 282 MB turbobot

🚮 Removed packages: npm/[email protected]

View full report↗︎

socket-security[bot] avatar Aug 08 '23 13:08 socket-security[bot]

Walkthrough

The changes involve updates to a button component library, including the introduction of new CSS variables for styling various button variants, the addition of new button components, and updates to existing button components. The updates include modifications to button styles, sizes, and states, as well as the introduction of new properties and methods in TypeScript files. Documentation and Storybook stories have been updated to reflect these changes, including deprecation notices and new usage examples.

Changes

File(s) Summary
.husky/pre-commit Added a shell script to call lefthook with different arguments based on available executables.
.storybook/storybook.css Removed import of tailwind.css, indicating a move away from global Tailwind utilities.
packages/.../outline-core-button/CHANGELOG.md Introduced @phase2/outline-core-button with version 0.0.1.
packages/.../outline-core-button/index.ts Exported OutlineCoreButton, ButtonVariant, and ButtonSize from the module.
packages/.../outline-core-button/src/css-variables/vars-*.css Added default CSS variables for various button variants (default, link, primary, secondary, tertiary).
packages/.../outline-core-button/src/outline-core-button*.css Updated button styles, including padding, border-radius, colors, and sizes.
packages/.../outline-core-button/src/outline-core-button.ts Added imports, types, properties, and methods to OutlineCoreButton class.
packages/.../outline-extended-button/index.ts Exported OutlineExtendedButton component.
packages/.../outline-extended-button/outline-extended-button*.css Updated CSS styles for OutlineExtendedButton with new classes and properties.
packages/.../outline-extended-button/outline-extended-button.ts Modified imports, added new button variant, and extended OutlineCoreButton.
packages/.../adopted-stylesheets/README.md Updated import statement to reflect module renaming.
packages/.../outline-storybook/config/storybook.main.css Reformatted code and added new CSS variables.
packages/.../outline-storybook/stories/components/outline-button.stories.ts Marked original button component as deprecated.
packages/.../outline-storybook/stories/components/outline-core-button.stories.ts Added new Storybook stories for button components with various configurations.
packages/.../outline-storybook/stories/components/outline-core-button.stories.mdx Added new documentation and examples for outline-core-button.
packages/.../controllers/adopted-stylesheets/CHANGELOG.md Updated version information for outline-adopted-stylesheets-controller.
packages/.../documentation/outline-storybook/CHANGELOG.md Updated version information for outline-core-button.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Oct 24 '23 13:10 coderabbitai[bot]

TODO: -review code rabbits typing suggestions -remove pre-commit nonsense

glitchgirl avatar Feb 06 '24 14:02 glitchgirl