outline icon indicating copy to clipboard operation
outline copied to clipboard

Fix animations

Open cristoferespindola opened this issue 1 year ago • 5 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Visual Testing
  • [ ] Automated Testing
  • [ ] Accessibility Testing

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

cristoferespindola avatar Jul 21 '23 20:07 cristoferespindola

⚠️ No Changeset found

Latest commit: 7d89ee1383fbd257214748b5c351d2c80e6859a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 21 '23 20:07 changeset-bot[bot]

Deploy Preview for outlinejs ready!

Name Link
Latest commit 7d89ee1383fbd257214748b5c351d2c80e6859a7
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/64baecede741d20008b78ef1
Deploy Preview https://deploy-preview-408--outlinejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 21 '23 20:07 netlify[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lit-labs/motion 1.0.3 None +0 155 kB lit-robot

socket-security[bot] avatar Jul 21 '23 20:07 socket-security[bot]

I'm not sure we want to force animations into core components as not every project may want them. Holding for review by Jake.

bardleb avatar Aug 01 '23 14:08 bardleb

TODO

  • Jake review

glitchgirl avatar Feb 06 '24 14:02 glitchgirl