outline icon indicating copy to clipboard operation
outline copied to clipboard

fix: Refactor styles.mjs to account for style generation order.

Open bkildow opened this issue 1 year ago • 4 comments

Description

  • Refactors the style generation script to always generate the light dom styles first in case other global styles depend on these (awaits the generations)
  • Gitignores *.scoped.css since this is a generated file

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Visual Testing
  • [ ] Automated Testing
  • [ ] Accessibility Testing

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

bkildow avatar Jun 12 '23 15:06 bkildow

⚠️ No Changeset found

Latest commit: 9deeec94751061364bfddfc8dc74019eaf0f6dec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 12 '23 15:06 changeset-bot[bot]

Deploy Preview for outlinejs ready!

Name Link
Latest commit 9deeec94751061364bfddfc8dc74019eaf0f6dec
Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/6487502613386600078c0cd7
Deploy Preview https://deploy-preview-401--outlinejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 12 '23 15:06 netlify[bot]

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives[^1] Size Publisher
glob 🆕 10.2.7 None +16 2.75 MB isaacs
[^1]: https://docs.socket.dev

socket-security[bot] avatar Jun 12 '23 15:06 socket-security[bot]

TODO: -discuss applicatiablity to current setup

glitchgirl avatar Feb 06 '24 14:02 glitchgirl