phantinuss

Results 28 comments of phantinuss

These were just open questions. I don't know how much need for it there actually is. (i.e. Me personally: If I want to get a list of changed files, I...

Hi, thanks for contributing. I am curious. Is there a specific reason for you to add this feature? We don't really use the output outside the build job like that....

There's some backlog, sorry. As a first time contributor the workflows won't run automatically. The first step is to look at the output of the failed tests and try to...

It depends on the workload. It's simply best effort.

Please have a look at other `product: gcp` rules. You need to traverse the JSON object for each field to access it. Also I don't see a `eventService` in the...

I don't see the `eventService` field in the example logs. I have to trust you on that/that it works. I'd prefer an example log that at least is matched by...

@Luke57 I am waiting for a second review. Rerequesting a review from me won't help as I already approved, sorry :)

Hi @tonifef, we are not ready to integrate Sigma v2 correlation rules to the rules repo yet. We will keep this PR open until we are ready to do so...

looks good to me. The error is on our side. I will pull in the fixes when they are merged.

From my POV this PR is good to merge but I also would be interested in an example log of the ping command error because the error would be shown...