chore: give back list of promoted rules
Summary of the Pull Request
tests/promote_rules_status.py gives back no output,
# .venv/bin/python3 tests/promote_rules_status.py; echo $?
0
And does not tell which rules when promoted. Now, the rules are given back.
Moreover, the building of artifacts is added into the promotion workflow.
Changelog
chore: update tests/promote_rules_status.py to return the promoted rules chore: .github/workflows/sigma-rule-promoter.yml to build artifacts of promoted rules
Example Log Event
Fixed Issues
SigmaHQ Rule Creation Conventions
- If your PR adds new rules, please consider following and applying these conventions
Hi,
thanks for contributing. I am curious. Is there a specific reason for you to add this feature? We don't really use the output outside the build job like that. Maybe there is another enhancement we can make (build artefact, add it to the message in the PR, ...)
Hi,
thanks for contributing. I am curious. Is there a specific reason for you to add this feature? We don't really use the output outside the build job like that. Maybe there is another enhancement we can make (build artefact, add it to the message in the PR, ...)
Your welcome, @phantinuss. I am new to the project, and I was looking into the test directory. I thought it would make a better user experience.
Sure, I'd be glad to work these tasks. I will push other PRs as this one is merged.
The changes some be done in the promotion workflow; right?
@phantinuss, here is the PR for review. I have added the building of artifacts in the promotion workflow.
Hello, any news on the PR? The force-push was for a rebase.
@phantinuss do we still want this?
@nasbench, the push force was for a rebase on master.
Looking forward your feedback. Thanks for the reminder.