sigma icon indicating copy to clipboard operation
sigma copied to clipboard

chore: give back list of promoted rules

Open ariel-anieli opened this issue 7 months ago • 6 comments

Summary of the Pull Request

tests/promote_rules_status.py gives back no output,

# .venv/bin/python3 tests/promote_rules_status.py; echo $?
0

And does not tell which rules when promoted. Now, the rules are given back.

Moreover, the building of artifacts is added into the promotion workflow.

Changelog

chore: update tests/promote_rules_status.py to return the promoted rules chore: .github/workflows/sigma-rule-promoter.yml to build artifacts of promoted rules

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

ariel-anieli avatar May 15 '25 16:05 ariel-anieli

Hi,

thanks for contributing. I am curious. Is there a specific reason for you to add this feature? We don't really use the output outside the build job like that. Maybe there is another enhancement we can make (build artefact, add it to the message in the PR, ...)

phantinuss avatar May 16 '25 08:05 phantinuss

Hi,

thanks for contributing. I am curious. Is there a specific reason for you to add this feature? We don't really use the output outside the build job like that. Maybe there is another enhancement we can make (build artefact, add it to the message in the PR, ...)

Your welcome, @phantinuss. I am new to the project, and I was looking into the test directory. I thought it would make a better user experience.

Sure, I'd be glad to work these tasks. I will push other PRs as this one is merged.

The changes some be done in the promotion workflow; right?

ariel-anieli avatar May 16 '25 11:05 ariel-anieli

@phantinuss, here is the PR for review. I have added the building of artifacts in the promotion workflow.

An example of the workflow output.

ariel-anieli avatar Jun 01 '25 21:06 ariel-anieli

Hello, any news on the PR? The force-push was for a rebase.

ariel-anieli avatar Sep 01 '25 10:09 ariel-anieli

@phantinuss do we still want this?

nasbench avatar Oct 19 '25 10:10 nasbench

@nasbench, the push force was for a rebase on master.

Looking forward your feedback. Thanks for the reminder.

ariel-anieli avatar Oct 20 '25 10:10 ariel-anieli