Oleg Grenrus

Results 547 comments of Oleg Grenrus

> It cannot traverse into Scopes, oops, the pattern constructor for LamF wants a Scope ... not an r: Exactly. It doesn't work correctly. With `-ddump-splices` ```haskell Test.hs:30:1-21: Splicing declarations...

I guess it's easy enough to extend the `isKonst`, do you want to try?

So what's it will mean to have ``` | Weird (ListT Exp a) | Weird (Exp [a]) ``` Will have a AST node type "of type" `a`, yet having commuting...

That would be a breaking change, as we have to move `PlotValue` out of `Graphics.Rendering.Chart.Axis.Types`. We *could* shim `Types`, to prevent breaking change, by introducting `Types.Internal`, but I'm not sure...

I see, renaming the class will work for me too.

One note: as there's `Graph` class, there could be `NonEmptyGraph`, (think `Monoid` and `Semigroup`). one could have e.g. ```haskell vertices1 :: NonEmptyGraph g => NonEmpty (Vertex g) -> g vertices1...

How these instances would work? `ToField`/ `FromField` instances are "leaf"s: parsing a cell value into haskell value. What `Generics` would do there? I can think of deriving for newtypes, but...

Enum case makes sense. 1-arity is suspicious. I'd suggest defining newtypes to be used with deriving via so the user tells what they want (instead of using clever generics trying...

Why stop at product types, Iso between SOP's which are equal. Yet that's just ```haskell generic . stripMedatata . from generic -- isn't it? ``` EDIT: reference [`generic`](https://hackage.haskell.org/package/lens-4.19/docs/GHC-Generics-Lens.html#v:generic)