haskell-chart icon indicating copy to clipboard operation
haskell-chart copied to clipboard

Published 20 hours ago • verified publisher icon timbod7

De-orphan PlotValue instances

Open phadej opened this issue 7 years ago • 3 comments

That would require small module juggling, but should be possible.

Motivation: haddock doesn't show orphan instances:

image

Which is unfortunate (I didn't realise there is Int instance for example)

phadej avatar Apr 14 '17 18:04 phadej

Most of this code is older than my knowledge that orphan instances were undesirable :-(

I'd definitely accept a PR for this, or, I can probably look at it in a few weeks time.

timbod7 avatar Apr 15 '17 01:04 timbod7

That would be a breaking change, as we have to move PlotValue out of Graphics.Rendering.Chart.Axis.Types. We could shim Types, to prevent breaking change, by introducting Types.Internal, but I'm not sure it's worth the trouble.

phadej avatar Apr 15 '17 08:04 phadej

I'm not averse to breaking changes for worthwhile improvements. I think that most usage of this library is for short term visualisations and is fairly ad-hoc in any case.

timbod7 avatar Apr 16 '17 05:04 timbod7