Pierre Gimalac
Pierre Gimalac
PS: thanks for the proper commit splitting, made reviewing much easier !
@dependabot recreate
@dependabot close This is outdated
`err` is `nil`, so calling `err.Error()` panics, this is expected Go behavior You might want to use `require.Error(t, err)` so that the test stops if `err` is `nil`, or use...
👋 Hey @dolmen @cszczepaniak, any update on this ? Would you consider a PR fixing this specifically ? (without necessarily going with the bigger https://github.com/stretchr/testify/issues/1439) I work on a project...
Works for me, as long as this is fixed ! I didn't notice you already had a PR opened by the way 😄
I ran the linter on the https://github.com/DataDog/datadog-agent repository (over 1.1M LoC in Go, including 400k lines of test) and found dozens of occurrences (at least 30). Most of them look...
Linking the testify PR which allowed using non-string if there's a single msg argument https://github.com/stretchr/testify/pull/699, for reference. It mentions it's to help with debugging so arguably that doesn't make it...
No worries I'm really not in a hurry, I can just disable the rule anyway !