datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-1319] Retry status command in status e2e tests

Open pgimalac opened this issue 1 year ago • 3 comments

What does this PR do?

Wrap the status test in an EventuallyWithT.

Motivation

The test started to flake due to the process-agent and trace-agent not being ready when we run the status command. Adding a grace period should solve it.

Additional Notes

IMO the framework shouldn't start the test until all agents that need to be ready are, but this is not how we currently do it in containers for example.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Mar 15 '24 17:03 pgimalac

[Fast Unit Tests Report]

Warning: On pipeline 30214259. The following jobs did not run any unit tests:

  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30214259 --os-family=ubuntu

pr-commenter[bot] avatar Mar 15 '24 18:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: e0d9636d-d53d-4a9e-a51d-f963147c00a0 Baseline: 1941f35b9b4c146b13cdf7422e9ad157f0fa7b31 Comparison: 583a5e722521a4690589fab3349e0db45a77006a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.49 [-6.82, +5.84]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +1.62 [+1.51, +1.73]
file_tree memory utilization +1.12 [+1.02, +1.21]
basic_py_check % cpu utilization +0.59 [-1.88, +3.05]
process_agent_real_time_mode memory utilization +0.33 [+0.29, +0.37]
trace_agent_json ingress throughput +0.02 [-0.00, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.01, +0.01]
otel_to_otel_logs ingress throughput -0.19 [-0.61, +0.23]
process_agent_standard_check memory utilization -0.24 [-0.27, -0.20]
process_agent_standard_check_with_stats memory utilization -0.30 [-0.34, -0.27]
idle memory utilization -0.31 [-0.34, -0.27]
file_to_blackhole % cpu utilization -0.49 [-6.82, +5.84]
uds_dogstatsd_to_api_cpu % cpu utilization -0.59 [-3.31, +2.12]
pycheck_1000_100byte_tags % cpu utilization -0.71 [-5.53, +4.12]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 15 '24 19:03 pr-commenter[bot]

/merge

pgimalac avatar Mar 18 '24 09:03 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 18 '24 09:03 dd-devflow[bot]