Pierre Gayvallet
Pierre Gayvallet
> will that be added in a separate PR or to this one? Likely in a follow-up, I'm not sure we have the capacity right now to work on this...
@LeeDr sorry, I see you added our team's label to the PR. What exactly is expected from us here? > And then there's the actual functionality in the product doesn't...
> go to https://github.com/elastic/kibana/blob/main/.buildkite/ftr_configs.yml#L52 (the line number may have changed) but you'll find it's excluded. But if you add it to the enabled list, I think it will fail. Yea,...
> Can you change back from global_banner_text to global banner text as was originally in the test? Nope. See https://github.com/elastic/kibana/pull/140688#discussion_r971632190
> Couldn't this PR just add the double-quotes here and include in this PR? We can, yes (even if I'm not sure to see the issue using a string without...
Some pointers: the server name comes from the `server.name` configuration option, which defaults to `os.hostname()`: https://github.com/elastic/kibana/blob/84db06c15d04bcaa011c41daf13ad1521deba604/packages/core/http/core-http-server-internal/src/http_config.ts#L37 The `kbn-name` header is set by an internal `pre-response` handler: https://github.com/elastic/kibana/blob/84db06c15d04bcaa011c41daf13ad1521deba604/packages/core/http/core-http-server-internal/src/lifecycle_handlers.ts#L66-L71 Which, in the...
Okay, so with just a bit of investigation: The actual 'single quote' char used in the default computer name in macOS settings is not a single quote (ascii 39), but...
Here, https://github.com/elastic/kibana/pull/141350
+1 for this, have been looking the doc for the subviews, seems very promising, but no infos anywhere.
``` │ERROR ERROR: Elasticsearch died while starting up, with exit code 1 ```