kibana
kibana copied to clipboard
Add a default 'User-Agent' HTTP header
Summary
Add a default User-Agent
HTTP header to requests made to Elasticsearch through the JavaScript Elasticsearch client. This field will be used to detect requests made by the client on behalf of Kibana from requests actually originating from the elasticsearch-js client.
Closes https://github.com/elastic/kibana/issues/136581
For maintainers
- [x] This was checked for breaking API changes and was labeled appropriately
However, this may be too complex for a contribution coming from outside of the team, so we could also do that as a follow-up, wdyt @rudolf ?
I agree an integration test would be good to have and that that's something we could own doing as well 👍
Thanks for reviews, I'll continue fixing tests. Agree an integration test would be lovely, will that be added in a separate PR or to this one? Happy to have this branch modified just let me know :)
will that be added in a separate PR or to this one?
Likely in a follow-up, I'm not sure we have the capacity right now to work on this branch/PR
will that be added in a separate PR or to this one?
Likely in a follow-up, I'm not sure we have the capacity right now to work on this branch/PR
Created an issue to keep track of this: https://github.com/elastic/kibana/issues/141287
@elasticmachine merge upstream
@elasticmachine merge upstream
:green_heart: Build Succeeded
- Buildkite Build
- Commit: c1d5314f2aa1ad5418f9bdd07cc8a4dc0178d3cc
Metrics [docs]
Public APIs missing comments
Total count of every public API that lacks a comment. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats comments
for more detailed information.
id | before | after | diff |
---|---|---|---|
@kbn/core-elasticsearch-client-server-internal |
10 | 11 | +1 |
Unknown metric groups
API count
id | before | after | diff |
---|---|---|---|
@kbn/core-elasticsearch-client-server-internal |
12 | 13 | +1 |
History
- :broken_heart: Build #74653 failed 8e2f40d3fe9c0417e46aa6553780302f0e4079f1
- :broken_heart: Build #74600 failed 23055d8e293c51ef780b0fc698e537728afb0460
- :broken_heart: Build #74261 failed 7863a0554f9394690062d88041ed88d72b5732c5
- :broken_heart: Build #74185 failed cb323f011256f422e2280640ea68de1140946026
- :broken_heart: Build #74142 failed 482012daae3312dcee091f676601c160c3f19f75
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
💚 All backports created successfully
Status | Branch | Result |
---|---|---|
✅ | 8.5 |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation
💚 All backports created successfully
Status | Branch | Result |
---|---|---|
✅ | 8.5 |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation and see the Github Action logs for details