Pengfei Li comments

Results 11 comments of


                                            Pengfei Li

8291669: [REDO] Fix array range check hoisting for some scaled loop iv

May I have another review for this REDO? Perhaps @vnkozlov @TobiHartmann

8291669: [REDO] Fix array range check hoisting for some scaled loop iv

Thanks for review. I will integrate this.

8291669: [REDO] Fix array range check hoisting for some scaled loop iv

/integrate

8289422: Fix and re-enable vector conditional move

/sponsor

8291466: C2: assert(false) failed: infinite loop in PhaseIterGVN::transform_old with -XX:+StressIGVN

/cc hotspot-compiler

8291466: C2: assert(false) failed: infinite loop in PhaseIterGVN::transform_old with -XX:+StressIGVN

PING. Any reviewer can help look at this? @shipilev

8291466: C2: assert(false) failed: infinite loop in PhaseIterGVN::transform_old with -XX:+StressIGVN

@chhagedorn Thanks for your review. Currently this patch has conflicts with jdk master. I will try a merge and then do the minor fixes as you suggested.

8291466: C2: assert(false) failed: infinite loop in PhaseIterGVN::transform_old with -XX:+StressIGVN

/integrate

Some IR tests still fail on MacOS/AArch64

Thanks for your quick fix. We now have 12 failures, 11 of which are just caused by the diff in assembly code. ``` ------------------------------- FAILED TESTS ------------------------------- 001: Argument Passing...

Some IR tests still fail on MacOS/AArch64

Just checked that there's no other failures, except those caused by the assembly difference. Thanks for it. >The other test failures most probably are false positives and may be avoided...