Paul Fultz II
Paul Fultz II
> Ah yes. The blanket hiding of exceptions. That's quite something. People complain about the unnecessary noise, because applicability checks do not always have 100% coverage in mlir and are...
> Would you like me to modify this PR to fix print_modules() instead and also add a fix for Embed.cmake? Yes please do.
> I also had a cursory look at other ROCm modules in regards to embedding files and I see MIOpen does it properly (https://github.com/ROCm/rocm-libraries/blob/develop/projects/miopen/cmake/embed.cmake#L68-L83), but there is the same problem...
The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.
> So could we use a better name to do reflect this ? We could, but cget would need to be updated to support such a name. There is this...
What is rocroller? Is TheRock building msgpack and distributing shared libraries of msgpack with rocm so other components that need msgpack will use that version? If so, migraphx should just...
@turneram Why did you close this?
Perf regression should be fixed by #3494.
If we could get the log with env variables `MIGRAPHX_TIME_MATCHERS=1 MIGRAPHX_TIME_PASSES=1` that would be helpful, Thanks!
This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why...