AMDMIGraphX
AMDMIGraphX copied to clipboard
ROCmSoftwarePlatform
SWDEV-451864 - Remove the hard coded path in MIGRAPHX_CXX_COMPILER
amdclang++/amdclang can be invoked without providing absolute path, since update-alternatives command has been run for these binaries This will also help to remove the hard coded paths in cmake target files for these compilers
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.02%. Comparing base (
22df950) to head (f34d90c). Report is 140 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #3377 +/- ##
========================================
Coverage 92.02% 92.02%
========================================
Files 509 509
Lines 21014 21014
========================================
Hits 19339 19339
Misses 1675 1675
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why this should be changed either as it doesnt affect any users.
This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why this should be changed either as it doesnt affect any users.
As part of our efforts to make ROCm relocatable , these hard coded paths need to be removed.
| Test | Batch | Rate new d68f73 |
Rate old fc26f0 |
Diff | Compare |
|---|---|---|---|---|---|
| torchvision-resnet50 | 64 | 3,240.31 | 3,261.06 | -0.64% | :white_check_mark: |
| torchvision-resnet50_fp16 | 64 | 6,881.20 | 6,993.61 | -1.61% | :white_check_mark: |
| torchvision-densenet121 | 32 | 2,428.60 | 2,434.05 | -0.22% | :white_check_mark: |
| torchvision-densenet121_fp16 | 32 | 4,063.94 | 4,095.98 | -0.78% | :white_check_mark: |
| torchvision-inceptionv3 | 32 | 1,634.23 | 1,638.20 | -0.24% | :white_check_mark: |
| torchvision-inceptionv3_fp16 | 32 | 2,736.94 | 2,759.48 | -0.82% | :white_check_mark: |
| cadene-inceptionv4 | 16 | 772.35 | 775.34 | -0.39% | :white_check_mark: |
| cadene-resnext64x4 | 16 | 807.91 | 808.43 | -0.06% | :white_check_mark: |
| slim-mobilenet | 64 | 7,443.76 | 7,536.82 | -1.23% | :white_check_mark: |
| slim-nasnetalarge | 64 | 207.54 | 211.47 | -1.86% | :white_check_mark: |
| slim-resnet50v2 | 64 | 3,343.96 | 3,501.50 | -4.50% | :red_circle: |
| bert-mrpc-onnx | 8 | 1,149.97 | 1,149.92 | 0.00% | :white_check_mark: |
| bert-mrpc-tf | 1 | 310.27 | 465.24 | -33.31% | :red_circle: |
| pytorch-examples-wlang-gru | 1 | 436.80 | 413.68 | 5.59% | :high_brightness: |
| pytorch-examples-wlang-lstm | 1 | 413.93 | 379.94 | 8.95% | :high_brightness: |
| torchvision-resnet50_1 | 1 | 758.89 | 786.00 | -3.45% | :red_circle: |
| cadene-dpn92_1 | 1 | 396.62 | 400.42 | -0.95% | :white_check_mark: |
| cadene-resnext101_1 | 1 | 379.09 | 381.26 | -0.57% | :white_check_mark: |
| onnx-taau-downsample | 1 | 344.32 | 343.07 | 0.36% | :white_check_mark: |
| dlrm-criteoterabyte | 1 | 35.09 | 33.36 | 5.17% | :high_brightness: |
| dlrm-criteoterabyte_fp16 | 1 | 57.41 | 52.73 | 8.88% | :high_brightness: |
| agentmodel | 1 | 9,998.70 | 8,550.08 | 16.94% | :high_brightness: |
| unet_fp16 | 2 | 57.87 | 58.85 | -1.66% | :white_check_mark: |
| resnet50v1_fp16 | 1 | 932.86 | 941.58 | -0.93% | :white_check_mark: |
| resnet50v1_int8 | 1 | 946.32 | 970.00 | -2.44% | :white_check_mark: |
| bert_base_cased_fp16 | 64 | 1,142.38 | 1,171.45 | -2.48% | :white_check_mark: |
| bert_large_uncased_fp16 | 32 | 351.83 | 363.62 | -3.24% | :red_circle: |
| bert_large_fp16 | 1 | 207.09 | 200.57 | 3.25% | :high_brightness: |
| distilgpt2_fp16 | 16 | 2,155.18 | 2,203.25 | -2.18% | :white_check_mark: |
| yolov5s | 1 | 502.12 | 540.96 | -7.18% | :red_circle: |
| tinyllama | 1 | 43.34 | 43.52 | -0.41% | :white_check_mark: |
| vicuna-fastchat | 1 | 172.37 | 174.66 | -1.31% | :white_check_mark: |
| whisper-tiny-encoder | 1 | 410.79 | 418.66 | -1.88% | :white_check_mark: |
| whisper-tiny-decoder | 1 | 425.47 | 428.20 | -0.64% | :white_check_mark: |
This build is not recommended to merge :red_circle:
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output