pfauchere

Results 11 comments of pfauchere
trafficstars

Hi, @anoack93 great to see Mavice implement support for Vue.js. You rock! I am wondering if using `ModelManager.initializeAsync()` [0] could help until #60 is resolved? Anyway, the latter function may...

Similar to [0] it could be that currently the component expects the booleans to be set to true when instantiating the class in JSX. @niekraaijmakers WDYT? https://github.com/adobe/aem-react-core-wcm-components/blob/master/react-base-components/src/authoring/download/v1/DownloadV1.tsx#L28-L30 [0] https://github.com/adobe/aem-react-core-wcm-components/issues/19#issuecomment-733796439

After discussing with @gabrielwalt , we expect the field to be displayed if the value exists in the JSON object.

Could you please provide comprehensive use-cases, and, ideally, content-packages?

Added a ticket to our internal backlog for the ModelRouter to support suffixes. Ref: CQ-4311149

@niekraaijmakers what about the suggested fix? https://github.com/adobe/aem-react-core-wcm-components/issues/17#issuecomment-715313022

@niekraaijmakers, is it that currently the component expects the booleans to be set to true when instantiating the class in JSX? https://github.com/adobe/aem-react-core-wcm-components/blob/master/react-base-components/src/authoring/list/v2/ListV2.tsx#L40-L41 Should the expectation of the implementation be that...

After discussing with @gabrielwalt , we expect the field to be displayed if the value exists in the JSON object.