Arthur Petukhovsky
Arthur Petukhovsky
Several places are using `dry.RandomBytes`: https://github.com/xelaj/mtproto/blob/8c4c69fd45ad5496bb0f291f6c4eb1750b2b9759/aes_ige/aes.go#L102-L104 https://github.com/xelaj/mtproto/blob/84baaf9e22783ea7d3abc83c805085441a1bda11/serialize/serialize.go#L59 And `dry.RandomBytes` is using math/rand to generate random bytes array. Maybe `dry.RandomBytes` should be using crypto/rand, or this package should implement its own...
- It looks like `etcd_info.timeline.commit_lsn > Some(self.local_timeline.get_last_record_lsn())` filtered all safekeepers in some strange cases. I removed this filter, it should probably fix #2237 - Now walreceiver_connection reports status, including commit_lsn....
In-memory timelines will be deactivated after there will be no compute connections for more than 10 minutes. Deactivation here will set `active = false` in `SharedState` struct and that will...
Safekeepers now have several per-timeline tasks (like S3 upload, trimming, broker) and the code behind it got complicated a bit. So, we have some tech debt and possibly some bugs....
## Steps to reproduce 1) Write at least one full WAL segment of data 2) Replace all safekeepers one by one, e.g. (sk1, sk2, sk3) -> (sk4, sk5, sk6) 3)...
https://github.com/neondatabase/neon/runs/7839377748?check_suite_focus=true ``` assert wal_size_after_checkpoint < 16 * 2.5 E assert 48.0 < (16 * 2.5) ``` Test checks that postgres will delete old WAL segments after they're broadcasted to safekeepers...
https://github.com/neondatabase/neon/runs/7834746692?check_suite_focus=true Found this in postgres logs: ``` 2022-08-15 08:46:34.261 GMT [3052] LOG: [NEON_SMGR] libpagestore: connected to 'postgresql://no_user:@localhost:18239' 2022-08-15 08:46:34.454 GMT [3052] LOG: execute __asyncpg_stmt_2731__: INSERT INTO query_log(index, verify_key) VALUES (6,...
Postgres can write multiline logs, and they are difficult to handle after they are mixed with other logs. This PR combines multiline logs from postgres into a single line, where...
``` + PG_BIN=/tmp/neon/pg_install/v16/bin + WAL_PATH='/tmp/test_output/test_wal_restore_initdb[release-pg16]/repo/safekeepers/sk1/956d95578c264511d8d0eada890c9991/cf5ea991f6ff2aeec1a9d4911b3aa9fb' + DATA_DIR='/tmp/test_output/test_wal_restore_initdb[release-pg16]/pgsql.restored' + PORT=30759 + echo port=30759 + echo 'shared_preload_libraries='\''$libdir/neon_rmgr.so'\''' ++ /tmp/neon/pg_install/v16/bin/pg_controldata -D '/tmp/test_output/test_wal_restore_initdb[release-pg16]/pgsql.restored' ++ grep -F 'REDO location' ++ cut -c 42- + REDO_POS=0x4EE9E8...
## Problem ## Summary of changes ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a...