James Petty

Results 20 comments of James Petty

I'm not sure if this is related or if I should open another issue for this, but the `swagger-custom-mappings.yml` suffers similar issues when dealing with `Option[A]` wrapped types. We make...

@kailuowang Ok, I'll open another issue. I tried using `Option\[MyType\]` and `scala\.Option\[MyType\]` and neither successfully overrode the property type.

@wuservices is this still an issue after https://github.com/iheartradio/play-swagger/pull/141 was merged into version https://github.com/iheartradio/play-swagger/releases/tag/v0.5.4 ?

Yeah, after thinking about this further- I think using `Option` and default query parameter values is a bad pattern without a clear implementation strategy. If a value is purely optional,...

@kailuowang a little awkwardness in reverse routing is probably to be expected here. I believe this is the router / reverse router abstraction leaking through. Anyway, I guess a special...

Would it be possible to verify this fix and publish a new version? The latest published release is definitely still impacted the issue (using Play 2.5).

@joprice I'm not sure exactly how that would work. Are you saying that by default it would parse the whole routing tree? Hooking to the root application router is definitely...

@joprice The 2nd workaround is totally fine with me. I just wanted I way to isolate the API resources from the other routes. Given that my preferred approach is going...

Pretty much everything in the stackdriver JVM plugin should be sent. What's the lift on making that happen? From the stackdriver docs, they make it sound like you just have...

https://cloud.google.com/monitoring/agent/plugins/jvm