Petri Savolainen

Results 75 comments of Petri Savolainen

You are missing some of the libavcodec ubuntu packages, or, if you have the right packages, Python is not able to find the shared libavcodec libraries. Check what you have,...

Thanks for pointing that out!

I'm working on a Skype connector; got a working proof of concept done that works ok with the Skype bot emulator. Reading the docs, it seems to me the implementation...

@jacobtomlinson thanks for pointing out the facebook connector - I did not realize server functionality could be provided so conveniently in opsdroid. Very nice. I did not mean to suggest...

Sigh. I am seeing similar `os.rename(tmp_loc, newloc)` failures in `_move_to_eggs_dir_and_compile`. But in this case, the error is `OSError: [Errno 20] Not a directory`. Upon investigating further, there already is an...

Ok in my case, this was because of old buildout in which there are checks in _move_to_eggs_dir_and_compile for pre-existing file and directory that cause removal of target first, but there...

~~Gahhh, the link issue is not fixed in newest 2.9.5 either~~ Bah. The link target (egg) was gone on my system but the link pointing to it was still there....

If you were to use something else than the built-in `json` for parsing, you'd probably want to also change https://github.com/scrapinghub/extruct/blob/master/extruct/jsonld.py#L38 that uses built-in `json` behind the scenes. You could use...

Re ^ just setting the date to a distant future value in the test, as a fix: how about instead adding a [delta](https://docs.python.org/3/library/datetime.html#timedelta-objects) to current timestamp?

BTW looks like we have another implementation as well (with a nice way to set the freeze end): https://github.com/TokenMarketNet/ico/blob/94517d20b5a2c6a7b52717a063f4870e76dec7d1/ico/tests/contracts/test_preico_proxy_buy.py#L54-L57 And both of these seem to have wrong return type in...