Petri Savolainen

Results 75 comments of Petri Savolainen

Thanks. I am not sure I understand what the example is supposed to do. Is it parsing some primitive draw operations (from a stream containing them) and converting those to...

@vaab, thanks for your most excellent response. I am humbled. You got it right: I had not thought of the "changelog when exported" - pattern that you described. And yes,...

Yes, the point of basename is removing common suffixes, prefixes etc. to leave just the base name. You're basically giving those suffixes/prefixes there, or combinations of them. What is the...

I suspected someone might have done this by now, and sure enough: https://pypi.org/project/iso-20275 . Since 2017, there now exists ISO standard 20275 ‘Financial Services – Entity Legal Forms (ELF).

For getting the base name without legal term affixes, the unique terms list from the ISO standard should probably be patched in here: https://github.com/psolin/cleanco/blob/master/cleanco/clean.py#L25-L29

This could be broken into two or three different tickets; * one for using in base name deduction * one for country decuction, and * one for legal entity detection.

Given we now understand more the differences between iso20275 data and cleanco termdata, it seems to me we need a decisions on data strategy. The current PR gets rid of...

Thank you. I did a quick google on the topic and this seems valid. Please, a github PR is welcomed if you can submit one.

@tubasal is "pty ltd" (or "pty limited") its own legal form or is this suffix just a concatenation of two different suffixes? You can get rid of multiple suffixes by...

I took a look at the term definitions. We don't have `pty` as a separate term, nor do we have `pty limited`. So this cannot work. Presuming the work on...