petreeftime

Yes, adding an encryption context would be useful for sure. Providing an API which can provide the request structure directly would probably work for this.

The enclave application shouldn't really care about the version exposed in this field, except maybe for debugging reasons, or for libraries to be able to provide backwards compatibility. For example,...

Last time I tested this, it didn't work for me. I'll take another look.

I no longer work on this project, so I will not be able to help, but it seems that minicbor_derive only supports encoding and decoding with indexed fields, rather than...

IMO, adding some unit tests with actual API responses from NSM would make it easy to discover such issues and prevent backwards incompatibility.

I looked into alternatives some time ago, and ciborium was missing some features and minicbor required significant work. I'll take another look, I see https://github.com/enarx/ciborium/issues/22 was finally closed and there's...

No, not at the moment. https://github.com/enarx/ciborium seems just about as unmaintained as `serde_cbor` and https://gitlab.com/twittner/minicbor would require some significant changes. The warning is that the project is unmaintained, which is...

Based on [RFC 8152 Section 4.2](https://tools.ietf.org/html/rfc8152#section-4.2), the tag is contextual, to prevent confusion between multiple structures. Since in the context of the Signed Attestation Document, it's clear that the object...

Either the code needs to be updated to emit a tag so that it matches the documentation, or the documentation needs to be updated to clarify that the tag might...

I'd be happy to review and merge your changes if you want to do a pull request with them.