aws-nitro-enclaves-nsm-api icon indicating copy to clipboard operation
aws-nitro-enclaves-nsm-api copied to clipboard

Published 20 hours ago • verified publisher icon aws

`serde_cbor` crate has been archived

Open raoulstrackx opened this issue 3 years ago • 7 comments
trafficstars

The serde_cbor crate has been archived. Is there a plan to deal with this?

raoulstrackx avatar Jan 24 '22 10:01 raoulstrackx

I looked into alternatives some time ago, and ciborium was missing some features and minicbor required significant work. I'll take another look, I see https://github.com/enarx/ciborium/issues/22 was finally closed and there's a new version of ciborium available, but it would mean dropping support for pre-1.56 Rust versions.

petreeftime avatar Jan 24 '22 11:01 petreeftime

Thanks for the fast reply @petreeftime! Much appreciated!

raoulstrackx avatar Jan 24 '22 11:01 raoulstrackx

@petreeftime any updates here? :)

emostov avatar May 18 '22 17:05 emostov

@petreeftime This causes cargo audit to fail. Any plans on looking into this issue? Thanks in advance.

vidhatha avatar Oct 06 '22 06:10 vidhatha

No, not at the moment. https://github.com/enarx/ciborium seems just about as unmaintained as serde_cbor and https://gitlab.com/twittner/minicbor would require some significant changes. The warning is that the project is unmaintained, which is true, but it seems stable and bug free. I am considering forking it or including it as a subcrate to provide additional maintenance when that will be needed, but at this point there is no real benefit to replace it and can be safely ignored in cargo-audit, unless someone feels strongly about replacing it (probably to minicbor, ciborium seems to be pretty much unmaintained) and provides a PR for it.

petreeftime avatar Oct 06 '22 07:10 petreeftime

No, not at the moment. https://github.com/enarx/ciborium seems just about as unmaintained as serde_cbor and https://gitlab.com/twittner/minicbor would require some significant changes. The warning is that the project is unmaintained, which is true, but it seems stable and bug free. I am considering forking it or including it as a subcrate to provide additional maintenance when that will be needed, but at this point there is no real benefit to replace it and can be safely ignored in cargo-audit, unless someone feels strongly about replacing it (probably to minicbor, ciborium seems to be pretty much unmaintained) and provides a PR for it.

@petreeftime #38 attempts to replace serde_cbor with minicbor.

emostov avatar Oct 10 '22 19:10 emostov

@petreeftime thanks for the response. Maybe we can look at @emostov attempts to replace serde_cbor

vidhatha avatar Oct 11 '22 12:10 vidhatha