Peter Wilson

Results 13 comments of Peter Wilson

Hi @tianhaopx, thanks for the submission. It looks good, I just wonder if you might be able to add a test to `secret_test.go` to check the return from `TokenPolicies`? I...

Hi @renatolabs, thanks for your submission! Please could I get you to add a change log entry (https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md#changelog-entries)?

Hi @bgshri , thanks for your submission. Are you able to go through the process of signing the CLA again please? The error message in Github maybe implies that a...

@Freyert, thanks for getting this started and all the work in figuring out the issue! I know I'd initially given some feedback on one of the PRs, but we’re going...

@Freyert your time and effort is much appreciated. What would be really useful would be to see if we can add a test which reproduces/validates this behaviour *before* we make...

@finnstech: https://github.com/hashicorp/vault/pull/18092 can be closed once this (`18137`) PR is merged.

Random, and not your code/docs etc. but any chance while you're in there you can fix this one thing that for some reason has been making my eye twitch: `docs/agent#configuration`:...

> @cawoodm Thanks for contributing to the docs! Please make sure to sign the CLA so we can merge your PR. @cawoodm please sign the CLA so that your contribution...

> Great job Pete! > > Thinking this through... I'm pretty sure this is going to break a lot of things related to metrics due to the (unfortunate IMO) design...

Handled by: * https://github.com/hashicorp/vault/pull/27041 * https://github.com/hashicorp/vault/pull/27031