peterwhitesell

Hey @xs5871, I did the isort and formatting fixes and pushed. `make test` didn't pass for me, but they are not passing for me on master either, and it's the...

Of course! first error: ```python kmk_firmware $ make test ./kmk/modules/autoshift.py:33:32: W601 .has_key() is deprecated, use 'in' make: *** [lint] Error 1 ``` if I fix that in autoshift.py, replacing `keyboard._hid_helper.has_key(KC.LSHIFT)`...

> 3.6 is ancient, try a current version. Indeed it is. Saw it in the docs somewhere. I also tried 3.9, as seen in the dockerfile, with the same results....

hey @xs5871, `make fix-isort` and `make fix-formatting` are passing for me now (🥳). I see `make test` is still failing, with actual test failures now, though they are failing on...

``` ..........match: 2 combo, within timeout assert mods: 0 == 0 keys: {'X'} == {'X'} matching?: True assert mods: 0 == 0 keys: set() == set() matching?: True match: 3...

the test failures are unrelated to this changeset (as they fail on master as well), but just being diligent here, running `make test` for each commit

hey @xs5871, I was planning to start writing documentation for the module. Is there anything major interface-wise that would be good to address before that? I believe the linting is...

@xs5871 totally understand it'll take a while to review 😃 just making sure I'm not holding up the review on my end. for full transparency I copied this code from...

I went ahead and pushed up some initial docs for the module as well

hey @xs5871 thank you for the review and feedback. It may take me some time to address, but just writing now to acknowledge receipt and thank you for the time