Peter Vandoros

Results 4 comments of Peter Vandoros

Add support for pre/post-apply/delete actions

Thanks for writing this up @samuelsuarezsanchez! I like the proposal :) Here's some feedback: - consider grouping all the "command hooks" under `hooks` or `command_hooks` instead of directly under the...

Specify which keys are valid when verifying requests

I haven't given this much thought yet, but I know that @Shervanator, @fraserxu, and @lukerobins have opinions on this from their recent work with adding API endpoints to marketplace for...

Fail to verify SSL identity when recursing into a host with a different SSL cert

We have hit this issue as well. I spent some time and created a PR that resolves the issues described in this issue and confirmed it working: https://github.com/github/gh-ost/pull/1487

Fail to verify SSL identity when recursing into a host with a different SSL cert

The above PR has been merged. Just waiting on a release.